docs(models): mark OnCallSchedule as provisional, add UUID hint (#333911)#35
Closed
KhaledSalhab-Develeap wants to merge 1 commit into
Closed
docs(models): mark OnCallSchedule as provisional, add UUID hint (#333911)#35KhaledSalhab-Develeap wants to merge 1 commit into
KhaledSalhab-Develeap wants to merge 1 commit into
Conversation
…t (#333911) Re-probed both production and test accounts via MCP on 2026-06-13; both still return zero on-call schedules, so the model fields cannot be validated against a real API response. Add a docstring note recording the probe date and describing what may be missing (rotation config, linked escalation policies). Update the uuid field description with the "sch_..." prefix observed in the tool schema.
Collaborator
Author
|
CI matrix:
All required checks passed. |
Collaborator
Author
|
Closing because this PR was spawned by a DarkTitan flow that was stopped mid-flight during fleet PR consolidation. The originating ticket is already DONE; the implementation can be re-spawned cleanly on top of current main when ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mark the
OnCallSchedulemodel as provisional and add implementation guidance for future verification. The model cannot be validated against real API responses because neither the production nor test account has any on-call schedules configured. This change documents the limitation and provides clear instructions for reconciliation once a schedule exists on a real account.What Changed
OnCallScheduledocstring to explain the model has not been validated against production API responsesmodel_extradue toextra="allow"uuidfield:"sch_..."Verification Matrix
"sch_..."Ticket Acceptance Criteria
Followups Not in This PR
Once at least one on-call schedule is created on the production or test account, ticket #333911 should be re-opened to:
OnCallSchedulemodel against the real response