Skip to content

docs(models): mark OnCallSchedule as provisional, add UUID hint (#333911)#35

Closed
KhaledSalhab-Develeap wants to merge 1 commit into
mainfrom
chore/333911-verify-oncall-schedule-model
Closed

docs(models): mark OnCallSchedule as provisional, add UUID hint (#333911)#35
KhaledSalhab-Develeap wants to merge 1 commit into
mainfrom
chore/333911-verify-oncall-schedule-model

Conversation

@KhaledSalhab-Develeap

@KhaledSalhab-Develeap KhaledSalhab-Develeap commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

Mark the OnCallSchedule model as provisional and add implementation guidance for future verification. The model cannot be validated against real API responses because neither the production nor test account has any on-call schedules configured. This change documents the limitation and provides clear instructions for reconciliation once a schedule exists on a real account.

What Changed

  • Updated OnCallSchedule docstring to explain the model has not been validated against production API responses
  • Added a note that neither the production nor test account had on-call schedules as of 2026-06-13
  • Documented that additional fields (rotation config, linked escalation policies) may exist in actual responses and will be captured in model_extra due to extra="allow"
  • Added format hint to the uuid field: "sch_..."
  • Cross-referenced ticket #333911 with instructions to re-run the MCP probe after creating a schedule

Verification Matrix

Check Result Notes
Code compiles No syntax errors
Docstring is accurate Reflects current state as of 2026-06-13
Format hint added to uuid Now shows "sch_..."
No model behavior changed Purely documentary

Ticket Acceptance Criteria

  • OnCallSchedule model is documented as provisional
  • Limitation is clearly explained (no schedules configured on either account)
  • Future verification steps are documented
  • UUID format hint is provided
  • Instructions reference ticket #333911 for followup when schedule becomes available

Followups Not in This PR

Once at least one on-call schedule is created on the production or test account, ticket #333911 should be re-opened to:

  • Re-probe the MCP endpoint to capture the actual response shape
  • Reconcile the OnCallSchedule model against the real response
  • Add/update fields as needed based on the actual API response structure

…t (#333911)

Re-probed both production and test accounts via MCP on 2026-06-13; both
still return zero on-call schedules, so the model fields cannot be
validated against a real API response.

Add a docstring note recording the probe date and describing what may be
missing (rotation config, linked escalation policies). Update the uuid
field description with the "sch_..." prefix observed in the tool schema.
@KhaledSalhab-Develeap

Copy link
Copy Markdown
Collaborator Author

CI matrix:

  • test (3.11): pass
  • test (3.12): pass
  • test (3.13): pass

All required checks passed.

@KhaledSalhab-Develeap

Copy link
Copy Markdown
Collaborator Author

Closing because this PR was spawned by a DarkTitan flow that was stopped mid-flight during fleet PR consolidation. The originating ticket is already DONE; the implementation can be re-spawned cleanly on top of current main when ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant